Skip to content

Commit

Permalink
fix(core/models): remove forceFormula from evaluateExpression
Browse files Browse the repository at this point in the history
  • Loading branch information
robzan8 committed Mar 22, 2023
1 parent 4dd3ef4 commit d0952ec
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,9 @@ import {AjfValidationResult} from '../../interface/validation/validation-results
export function evaluateValidation(
validation: AjfValidation,
context?: AjfContext,
forceFormula?: string,
): AjfValidationResult {
return {
result: evaluateExpression(validation.condition, context, forceFormula),
result: evaluateExpression(validation.condition, context),
error: validation.errorMessage,
clientValidation: validation.clientValidation,
};
Expand Down
3 changes: 1 addition & 2 deletions projects/core/forms/src/utils/warning/evaluate-warning.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@ import {AjfWarningResult} from '../../interface/warning/warning-result';
export function evaluateWarning(
warning: AjfWarning,
context?: AjfContext,
forceFormula?: string,
): AjfWarningResult {
return {
result: evaluateExpression(warning.condition, context, forceFormula),
result: evaluateExpression(warning.condition, context),
warning: warning.warningMessage,
};
}
8 changes: 2 additions & 6 deletions projects/core/models/src/utils/expression-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,8 @@ function cloneMainForms(forms: MainForm[]): MainForm[] {
return res;
}

export function evaluateExpression(
expression: string,
context?: AjfContext,
forceFormula?: string,
): any {
return createFunction(forceFormula || expression)(context);
export function evaluateExpression(expression: string, context?: AjfContext): any {
return createFunction(expression)(context);
}

type Func = (c?: AjfContext) => any;
Expand Down

0 comments on commit d0952ec

Please sign in to comment.