Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to dart 3 #4

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: update to dart 3 #4

merged 1 commit into from
Aug 31, 2023

Conversation

gnudles
Copy link
Owner

@gnudles gnudles commented May 29, 2023

No description provided.

@gnudles
Copy link
Owner Author

gnudles commented May 29, 2023

Hi, thanks.
Can you update the version number in the pubspec, to 1.0.0, and also add some notes in the changelog?
Another thing.... if we move to version 3, maybe we no longer want null-safe to be optional, but mandatory? so the version check should be removed. But if we keep it optional, then all the "reorder**" new strings should be included by condition

@gnudles gnudles mentioned this pull request May 29, 2023
@lvxduck
Copy link
Contributor

lvxduck commented May 30, 2023

I think that we should remove the version check because Dart 3 requires sound null safety. If anyone needs unsound null safety, they can use the lower version.

@gnudles gnudles changed the base branch from main to dart3 August 31, 2023 17:56
@gnudles gnudles merged commit 96153af into gnudles:dart3 Aug 31, 2023
@gnudles
Copy link
Owner Author

gnudles commented Aug 31, 2023

published the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants