[BUGFIX] Make class name visitors ignore ::class tokens #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[bump] @gnugat |
|
Hi @fabschurt, thank you for your contribution. |
|
Perfect, thanks! 👍 |
|
@gnugat, just as a side note: it seems that the new release ( |
|
Thanks for pointing it out, I've updated manually packagist and reset the webhook for the next times. |
|
Nice, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently, the class name visitors support the
T_CLASStoken type, but this token type can refer to a regular class declaration AND to aclassmagic constant (::class). So, if there are calls to::classin the class body, an error will likely be thrown because the next tokens will surely not be a whitespace and a string/class name.This PR fixes this by making sure we’re dealing with a class declaration keyword and not a class magic constant.