Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate generic_mod, work over narrowband examples #1956

Open
marcusmueller opened this issue Aug 17, 2018 · 1 comment
Open

Deprecate generic_mod, work over narrowband examples #1956

marcusmueller opened this issue Aug 17, 2018 · 1 comment
Assignees
@marcusmueller
Labels
Cruft digital examples Low Issues of low priority.
Projects
Release 3.9
Milestone
Release 3.9

Comments

@marcusmueller
Copy link
Member

Basically, everywhere that generic_mod / type_1_mods is used should be deprecated, since these no longer contain many useful constellations.
@marcusmueller marcusmueller added this to the Release 3.9 milestone Aug 17, 2018
@marcusmueller marcusmueller self-assigned this Aug 17, 2018
marcusmueller added a commit to marcusmueller/gnuradio that referenced this issue Aug 17, 2018
@marcusmueller
Delete deprecated (q)d/qpsk and qam python hier blocks.
2345321 
Fixes gnuradio#1081.

These blocks were just overly specific wrappers for RRC + constellation
decoders/encoders.

With the nice constellation objects, no need to keep these around.

Note that they are still in use as *possible* constellations
(runtime-detected) in examples like narrowband/tunnel.py, but reducing
these in functionality is inavoidable at this point. Progress of
updating them is tracked in gnuradio#1956.
marcusmueller added a commit to marcusmueller/gnuradio that referenced this issue Aug 17, 2018
@marcusmueller
Add deprecation warning to narrowband examples using type_1_(de)mods()
e0faf2d 
In accordance to gnuradio#1956.
@marcusmueller marcusmueller mentioned this issue Aug 17, 2018
Merged
marcusmueller added a commit that referenced this issue Aug 23, 2018
@marcusmueller
Delete deprecated (q)d/qpsk and qam python hier blocks.
9fa0098 
Fixes #1081.

These blocks were just overly specific wrappers for RRC + constellation
decoders/encoders.

With the nice constellation objects, no need to keep these around.

Note that they are still in use as *possible* constellations
(runtime-detected) in examples like narrowband/tunnel.py, but reducing
these in functionality is inavoidable at this point. Progress of
updating them is tracked in #1956.
marcusmueller added a commit that referenced this issue Aug 23, 2018
@marcusmueller
Add deprecation warning to narrowband examples using type_1_(de)mods()
2db0a46 
In accordance to #1956.
@devnulling devnulling added this to To do in Release 3.9 via automation Jan 5, 2020
@mormj mormj mentioned this issue Mar 5, 2021
Closed
@marcusmueller
Copy link
Member Author

outstanding issue, but might not have high priority since decruftification of the 3.x code base won't entail removing parts of the ecosystem

@marcusmueller marcusmueller added the Low Issues of low priority. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusmueller marcusmueller

Labels
Cruft digital examples Low Issues of low priority.
Projects
No open projects
Release 3.9
  
To do
Milestone
Release 3.9
Development

No branches or pull requests
1 participant
@marcusmueller