Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gr-digital: symbol_sync_ff_impl uses deprecated Boost header #2712

Closed
marcusmueller opened this issue Aug 8, 2019 · 0 comments · Fixed by #3337
Closed

gr-digital: symbol_sync_ff_impl uses deprecated Boost header #2712

marcusmueller opened this issue Aug 8, 2019 · 0 comments · Fixed by #3337

Comments

@marcusmueller
Copy link
Member

In file included from /usr/include/boost/config/header_deprecated.hpp:18,
                 from /usr/include/boost/math/common_factor_ct.hpp:14,
                 from /usr/include/boost/math/common_factor.hpp:13,
                 from /buildbot/gnuradio/gr-digital/lib/symbol_sync_ff_impl.cc:28:
/usr/include/boost/math/common_factor_ct.hpp:16:1: note: #pragma message: This header is deprecated. Use <boost/integer/common_factor_ct.hpp> instead.
   16 | BOOST_HEADER_DEPRECATED("<boost/integer/common_factor_ct.hpp>");
      | ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/math/common_factor_rt.hpp:13:1: note: #pragma message: This header is deprecated. Use <boost/integer/common_factor_rt.hpp> instead.
   13 | BOOST_HEADER_DEPRECATED("<boost/integer/common_factor_rt.hpp>");
      | ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/math/common_factor.hpp:16:1: note: #pragma message: This header is deprecated. Use <boost/integer/common_factor.hpp> instead.
   16 | BOOST_HEADER_DEPRECATED("<boost/integer/common_factor.hpp>");
      | ^~~~~~~~~~~~~~~~~~~~~~~

Boost deprecations are the wurst, since Boost seldom cleanly documents since when a new function is available from a certain file, so you end up in git-bisect, and then Ubuntu comes along and happily mixes versions of boost sublibraries. Often, only #ifdefs on Boost versions are a viable solution :/

A future-bound #ifdef __cplusplus >= 201703L using std::lcm might be cool when fixing this.

japm48 added a commit to japm48/gnuradio that referenced this issue Apr 10, 2020
Remove deprecation warning and prefer using std::{lcm,gcd} to Boost.
Fixes gnuradio#2712.
japm48 added a commit to japm48/gnuradio that referenced this issue Apr 10, 2020
Remove deprecation warning and prefer using std::{lcm,gcd} to Boost.
Fixes gnuradio#2712.
japm48 added a commit to japm48/gnuradio that referenced this issue Apr 10, 2020
Remove deprecation warning and prefer using std::{lcm,gcd} to Boost.
Fixes gnuradio#2712.
japm48 added a commit to japm48/gnuradio that referenced this issue Apr 10, 2020
Remove deprecation warning and prefer using std::{lcm,gcd} to Boost.
Fixes gnuradio#2712.
marcusmueller pushed a commit that referenced this issue Apr 11, 2020
Remove deprecation warning and prefer using std::{lcm,gcd} to Boost.
Fixes #2712.
ekigwana pushed a commit to ekigwana/gnuradio that referenced this issue Jul 20, 2020
Remove deprecation warning and prefer using std::{lcm,gcd} to Boost.
Fixes gnuradio#2712.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant