Max block does not work in GRC when IO Type is Short #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anion when its IO Type is set to Short.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a typo in blocks_max_xx.xml, the Max block does not work in GNU Radio Companion when the IO Type is set to Short.
To reproduce the problem, create a flow graph with a null source connected to a Max block connected to a null sink, and set all three blocks to use Short. Click the execute button, and you'll see the following error:
Traceback (most recent call last):
File "/home/argilo/Documents/gnuradio/top_block.py", line 62, in
tb = top_block()
File "/home/argilo/Documents/gnuradio/top_block.py", line 34, in init
self.blocks_max_xx_0 = blocks.max_dd(1)
AttributeError: 'module' object has no attribute 'max_dd'
After applying this patch, the flow graph executes correctly.