Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket_pdu_impl.cc: fix build with boost 1.70.0 #2451

Closed
wants to merge 1 commit into from
Closed

socket_pdu_impl.cc: fix build with boost 1.70.0 #2451

wants to merge 1 commit into from

Conversation

ffontaine
Copy link

Fix #2446

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

@ffontaine
socket_pdu_impl.cc: fix build with boost 1.70.0
6b450f3 
Fix #2446

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@michaelld
Copy link
Contributor

I think this is a good solution to the Boost issue here. We need to test it to verify, which means installing Boost 1.70.0 ... which might take a bit so please have patience!

@michaelld michaelld mentioned this pull request Apr 19, 2019
Closed
@marcusmueller marcusmueller added this to To Do (Committed) in Release 3.8 via automation Apr 21, 2019
SoapGentoo
SoapGentoo reviewed May 1, 2019
View reviewed changes
gr-blocks/lib/socket_pdu_impl.cc
#define GET_IO_SERVICE(s) ((boost::asio::io_context&)(s)->get_executor().context())
#else
#define GET_IO_SERVICE(s) ((s)->get_io_service())
#endif
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended in boostorg/asio@59066d8#commitcomment-33184421
The 1.70 cast is potentially unsafe

@michaelld
Copy link
Contributor

As noted already, the cast is potentially unsafe. We also have the issue that boost::asio::io_service is being deprecated starting as of starting in 1.66.0, replaced directly by boost::asio::io_context. So ... let's just get these all fixed up together shall we?! There's a better way to implement the various parts here that will build cleanly on the current Boost as well as prior ones, which does not involve the potentially unsafe cast. Thus, thank you for the prod to get this fixed; I'm closing this ticket & will submit another PR with the more comprehensive fix. I'll make sure this PR is noted for reference.

@michaelld michaelld closed this May 2, 2019
Release 3.8 automation moved this from To Do (Committed) to Done May 2, 2019
@michaelld michaelld mentioned this pull request May 2, 2019
Closed
@erikheinz erikheinz mentioned this pull request May 20, 2019
Closed
michaelld added a commit to michaelld/gnuradio that referenced this pull request May 23, 2019
@michaelld
blocks: simple fix for Boost 1.70.0 in socket_pdu
6dc8229 
NOTE: There have been multiple fixes proposed, such as
gnuradio#2451 .
This one is the simplest and most compatible.
@michaelld michaelld mentioned this pull request May 23, 2019
Merged
mbr0wn pushed a commit that referenced this pull request May 28, 2019
@michaelld @mbr0wn
blocks: simple fix for Boost 1.70.0 in socket_pdu
c01473b 
NOTE: There have been multiple fixes proposed, such as
#2451 .
This one is the simplest and most compatible.
@scpeters scpeters mentioned this pull request May 30, 2019
Closed
hcab14 pushed a commit to hcab14/gnuradio that referenced this pull request Jun 1, 2019
@michaelld @hcab14
blocks: simple fix for Boost 1.70.0 in socket_pdu
9ab4eac 
NOTE: There have been multiple fixes proposed, such as
gnuradio#2451 .
This one is the simplest and most compatible.
mormj pushed a commit to mormj/gnuradio that referenced this pull request Jun 5, 2019
@michaelld @mormj
blocks: simple fix for Boost 1.70.0 in socket_pdu
6500e75 
NOTE: There have been multiple fixes proposed, such as
gnuradio#2451 .
This one is the simplest and most compatible.
AlexandraTrifan pushed a commit to analogdevicesinc/gnuradio that referenced this pull request Jul 17, 2019
@michaelld @AlexandraTrifan
blocks: simple fix for Boost 1.70.0 in socket_pdu
e836e70 
NOTE: There have been multiple fixes proposed, such as
gnuradio#2451 .
This one is the simplest and most compatible.
AlexandraTrifan pushed a commit to analogdevicesinc/gnuradio that referenced this pull request Jul 29, 2019
@michaelld @AlexandraTrifan
blocks: simple fix for Boost 1.70.0 in socket_pdu
025ac60 
NOTE: There have been multiple fixes proposed, such as
gnuradio#2451 .
This one is the simplest and most compatible.
michaelld added a commit to michaelld/gnuradio that referenced this pull request Aug 14, 2019
@michaelld
blocks: simple fix for Boost 1.70.0 in socket_pdu
861d782 
NOTE: There have been multiple fixes proposed, such as gnuradio#2451 .
This one is the simplest and most compatible.

This is a backport of the same fix for GR38: gnuradio@c01473b
@michaelld michaelld mentioned this pull request Aug 14, 2019
Merged
michaelld added a commit that referenced this pull request Aug 26, 2019
@michaelld
blocks: simple fix for Boost 1.70.0 in socket_pdu
c445ef1 
NOTE: There have been multiple fixes proposed, such as #2451 .
This one is the simplest and most compatible.

This is a backport of the same fix for GR38: c01473b
@g1itch g1itch mentioned this pull request Sep 13, 2019
Closed
mormj pushed a commit to mormj/gnuradio that referenced this pull request Apr 3, 2020
@michaelld @mormj
blocks: simple fix for Boost 1.70.0 in socket_pdu
9049d47 
NOTE: There have been multiple fixes proposed, such as
gnuradio#2451 .
This one is the simplest and most compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoapGentoo SoapGentoo SoapGentoo left review comments

Assignees
No one assigned
Labels
blocks boost dependencies
Projects
No open projects
Release 3.8
  
Done
Milestone
No milestone
4 participants
@ffontaine @michaelld @SoapGentoo @marcusmueller