runtime: prefs: parse user config even if sys conf dir isn't a directory #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, this lead to systems where due to missing system paths, a user couldn't even use their own config file, because GNU Radio didn't even look for it.
mbr0wn
approved these changes
Jun 19, 2019
| if(p.extension() == ".conf") | ||
| fnames.push_back(p.string()); | ||
| } | ||
| std::sort(fnames.begin(), fnames.end()); |
There was a problem hiding this comment.
Both in the old and new code I'm not entirely sure what this sort does, but it's not an issue with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from helping a user on the mailing list (hi there, Gary),
who's been having severe problems with the Windows audio source; told
him to configure GNU Radio to use portaudio instead. He did - but GR
ignored his config file. Turned out that the hardcoded path to the
system config dir (set at built) doesn't match how it was installed on
Windows, and that prefs don't even try the user confs if they can't find
that directory. Fixed that.