GR37 thrift fixes #2738
Closed
GR37 thrift fixes #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wishing there were a better way to handle the selection of either |
|
I quite like everything about this, even if it's very version-specific |
I have a PR coming for GR38 ... hopefully tomorrow. Their code bases have diverged somewhat so I have to redo most of the patches to be GR-version specific. |
This was referenced Aug 15, 2019
|
Ping on this issue ... please let's deal with it before it gets stale! |
|
Closing in favor of rebased & reformatted #3869. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows building GR37 +ctrlport +ctrlport::thrift using Thrift 0.9.2 through current (0.12.0). Builds and passes
make testusing Thrift 0.10.0, 0.11.0, and 0.12.0 on OSX.