-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new menu option under 'Help' for Keyboard-Shortcuts. #3176
Conversation
@alekhgupta1441 thanks for the PR. A few things:
https://github.com/gnuradio/gnuradio/blob/master/CONTRIBUTING.md In order to get the process rolling, please email "bhilburn AT gnuradio.org" for a form to start the copyright process.
i think it would be better to add a new menu option under "Help" such as "Keyboard Shortcuts" that would open up a different alert/popup window, where this info would be at. |
One more request, the commit message should prefix the section of code that it changes for example: grc: Extend the help menu |
I have mailed for CLA prcoess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sounds like @alekhgupta1441 wants to update it to address the small screen size issue, and we're also waiting on the CLA, but should be good to go after that. |
cd2e01d
to
f316b35
Compare
Sorry, for being quite late. |
@michaelld,@marcusmueller,@devnulling, @777arc can you please review this? |
@alekhgupta1441 I don't see the keyboard shortcuts menu, is it supposed to be listed under Help? Control-K doesn't do anything for me either. -Marc |
@777arc Yes, Keys menu option is under 'Help' and CTRL +K opens Keyboard Shortcuts menu.I checked it again by building gnuradio from branch alekh_gr. |
Oops had PYTHONPATH issues. Yeah looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks safe to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All looks good here: CLA; multiple approvals; relatively simple And useful addition. Merging. |
@777arc , @michaelld, @nickoe Thanks for Reviewing and Merging PR. |
@michaelld @alekhgupta1441 @marcusmueller Do we want this on maint-3.8 as well, or should we ignore that? |
I just tested this as a cherry-pick on maint-3.8 and it seem to work well. But this is only testing with python3. |
Fixes #3148
Included keyboard shortcuts in 'Help' menu.