cmake: declare compatibility with 3.8 #3187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey ;) so, I saw the discussion you had on osmocom-sdr Friday, and forgot to answer, sorry. So, how is upstream supposed to know what a breaking change is, for all the modules in the world? Thus, I disagree with @smunaut. I'll hook into that discussion on the osmo mailing list (For context: link to thread) and we'll sort this out, together. However, I really can't add a "we're probably compatible" flag, somewhere hidden in a generated CMake file, I'm afraid :( |
|
Hoping to sort this out in #3188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many 3.8-compatible out-of-tree modules refuse to build with GNU Radio's master branch because they request GNU Radio 3.8, while the master branch calls itself 3.9 and declares itself incompatible with 3.8. With a modification to
GnuradioConfigVersion.cmakeGNU Radio can declare that it is still compatible with 3.8.Perhaps the check should be more nuanced, but this might be reasonable as a quick fix. The extra check could be reverted if any major compatibility-breaking changes appear.