cmake: GrPython: make set_target_properties call suitable for older cmake #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make Signed-off-by: Jeff Long <willcode4@gmail.com>
mbr0wn
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Use
set_target_properties/INTERFACE_LINK_LIBRARIESinstead oftarget_link_librarieswhen configuring Numpy inGrPython.cmake. This is needed for older versions of CMake, such at the one on Ubuntu 18.04, which has cmake 3.10.2. The newer function is not available until 3.13.Related Issue
Fixes #5115
Checklist