blocks/wavfile_source: fix case where we'll loop producing zero forever #7108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to update the pybind11 bindings for wavfile.h. Also, since you're in here, maybe address #5971 ? |
|
PyBind11 hash needs updating. Looks good. The name |
|
True, but I can still rename that if it's conductive to readability, while I'm at it |
marcusmueller
force-pushed
the
wavfile_src_handle_file_end
branch
from
2711c9d
to
1021b55
Compare
|
huh unit test failures I didn't see. wat. |
This required checking for actual return amount in-loop; also, do not assume that length of a file fits in an int; there's files longer than 2³¹. Be clear about ignored sndfile errors. Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
marcusmueller
force-pushed
the
wavfile_src_handle_file_end
branch
from
1021b55
to
e3f5c90
Compare
drmpeg
reviewed
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required checking for actual return amount in-loop; also, do not assume that length of a file fits in an int; there's files longer than 2³¹.
Be clear about ignored sndfile errors.
Signed-off-by: Marcus Müller mmueller@gnuradio.org
Description
Related Issue
Fixes #6435
Which blocks/areas does this affect?
wavfile source
Testing Done
tests continue to pass, and the supplied example ogg that used to fail now finishes
Checklist