grc-qt: Fixing incorrect error display #7287
Open
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gnuradio#7248 In addition: If on startup grc loads an invalid flowgraph, the fg is shown as valid, that is the error button is disabled. If there are several tabs ar open that contain a mixture of valid and invalid fg's the error button is not adopted to the status of the selected tab. This pr calculates the status of the buttons individually for each tab depending on it's fg. Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
|
This commit Fixes: #7305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7284
In addition:
If on startup grc loads an invalid flowgraph, the fg is shown as valid, that is the error button is disabled.
If there are several tabs ar open that contain a mixture of valid and invalid fg's the error button is not adopted to the status of the selected tab.
This pr calculates the status of the buttons individually for each tab depending on it's fg.
Related Issue
Fixes #7284
Testing Done
Build a simple fg, save it, delete a connection. Save the fg again.
Restart grc --qt
The fg should display an error as a connection is missing.
Open several tabs with an mixture of correct and incorrect fg's and switch between the different tabs.
Watch the status of the 'errors' button
Checklist