Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a QTGUI edit box block that emits a message when changed. #746

Merged
merged 1 commit into from Apr 26, 2016

Conversation

trondeau
Copy link
Contributor

Unlike the current QT GUI Entry Widget, this is an actual GNU Radio
block with an output message port 'msg'. When the editing is finished
(enter or change in scope), it triggers the editing_finished method
that publishes the text in the box as a message.

Also allows setting of the value through an input message port.

Adds example test_qtgui_msg.grc to explore this.

@osh
Copy link
Member

osh commented Feb 11, 2016

+1

@jmcorgan
Copy link
Contributor

I like the static key option, but can we make it that when the key is static, it doesn't have it showing next to the entry box? This would make it look just like any other entry widget, except it uses messages instead of calling functions.

@trondeau
Copy link
Contributor Author

I had considered that, but I left it in to be clear what the edit box was doing. I was considering making it the label, but I think there's value in a user-set label that might me more human readable than the key. But showing the key makes it clear what's happening with that widget. The nice thing is that the block auto-scales the width of the box to just fit the key to reduce wasted space.

Another option might be to have a popup box when you hover over it that displays the key or even the key:value PMT it will create.

@trondeau trondeau force-pushed the qtgui_msg_edit branch 2 times, most recently from fd91de4 to df2531c Compare March 9, 2016 17:05
@trondeau trondeau force-pushed the qtgui_msg_edit branch 5 times, most recently from 3ab7343 to 5a5b87d Compare April 26, 2016 18:32
Unlike the current QT GUI Entry Widget, this is an actual GNU Radio
block with an output message port 'msg'. When the editing is finished
(enter or change in scope), it triggers the editing_finished method
that publishes the text in the box as a message.

Also allows setting of the value through an input message port.

Adds example test_qtgui_msg.grc to explore this.
@jmcorgan jmcorgan merged commit 46e4978 into gnuradio:master Apr 26, 2016
@trondeau trondeau deleted the qtgui_msg_edit branch May 5, 2016 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants