Tags and rate changing blocks #758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thin work. Because the relative rate can change within this block's work function, applying the same update to the tag offets after work does not work. Instead, we use TPP_DONT and handle the placement of the tags on the output buffer ourselves.
Same concept as used in the PFB clock sync blocks.
Use generate_samples.grc to build a file of burst QPSK, then use test_timing_tags.grc to view the results. Tags should show up on the first bit of the data stream (four 1's followed by four -1's).
|
Seeing some other issues elsewhere when I'm using this. Need to verify the tag placement. |
|
Any update on this? |
|
Negative. Haven't found time to follow through with the tests that I need to run. |
|
Going to close this because I have a better solution on my packet2 branch. See This would need to be applied (and tested) for both complex and float versions of the PFB and M&M clock sync blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bug fix, technically, but it's a pretty significant change in the internal behavior of the blocks with how they handle the tags. It will also add overhead in how the tags are managed, and I'm not sure by how much exactly.