Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In utils/subproc.py: Change threading.Thread monitor_thread method isAlive to is_alive #588

Merged
merged 2 commits into from Nov 13, 2020
Merged

In utils/subproc.py: Change threading.Thread monitor_thread method isAlive to is_alive #588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20d70d
In utils/subproc.py: Change threading.Thread.isAlive to threading.Thr…
us3rnotfound Oct 7, 2020
d59ccf7
adding parentheses (see PR discussion)
jkbecker Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pybombs/utils/subproc.py
View file
Open in desktop
Expand Up @@ -240,7 +240,7 @@ def monitor_process(args, **kwargs):
args=(quit_event, args, kwargs)
)
monitor_thread.start()
while monitor_thread.isAlive:
while monitor_thread.is_alive():
# Try if it's finished:
monitor_thread.join(1)
if quit_event.is_set() or not monitor_thread.is_alive():
Expand Down