Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gr-nacl recipe #4

Merged
merged 2 commits into from
Apr 22, 2015
Merged

add gr-nacl recipe #4

merged 2 commits into from
Apr 22, 2015

Conversation

stwunsch
Copy link
Contributor

Libsodium dependency not included in recipe (needs to be compiled and installed by hand, is not available via package manager), installation is fully explained in gr-nacl/README.md

@jmcorgan
Copy link
Contributor

Pybombs can automate building libsodium; it looks like it uses autoconf.

@stwunsch
Copy link
Contributor Author

Ok thanks, I have not seen that. But I think I have fixed it. It builds fine on my system.

But probably the cmake module for finding libsodium in gr-nacl is a little bit messy. ->
https://github.com/stwunsch/gr-nacl/blob/master/cmake/Modules/FindSodium.cmake

If the folder structure in pybombs does not change, this should work. Unfortunately I can't use the pkg-config in the FindModule (if I understand this cmake stuff right) and I don't know a better solution for this.

@jmcorgan
Copy link
Contributor

What I mean is, you can create a recipe for libsodium and list that as a dependency for gr-nacl. Pybombs will then be able to download, compile from source, and install libsodium into $PREFIX. Then your gr-nacl CMake script can find the header and .so file the usual way.

@stwunsch
Copy link
Contributor Author

What I mean is, you can create a recipe for libsodium and list that as a dependency for gr-nacl. Pybombs will then be able to download, compile from source, and install libsodium into $PREFIX.

This is done (see second commit). I have created a libsodium recipe and put it as dependency in gr-nacl. Download, compile and install in $PREFIX works.

Then your gr-nacl CMake script can find the header and .so file the usual way.

What do you mean with this? What is the 'usual way' to find a package if it is not installed with the package management and therefore can not be found by pkg-config?

@mbr0wn
Copy link
Member

mbr0wn commented Apr 19, 2015

CMake has its own routines for finding libs and header files.

@stwunsch
Copy link
Contributor Author

Ok sry, finally I got it. New generic FindModule ->

https://github.com/stwunsch/gr-nacl/blob/master/cmake/Modules/FindSodium.cmake

I missed that libsodium ships a libsodium.pc file with its installation and the target in pybombs has an own pkgconfig folder so that I don't have to search the library with hard-coded or default paths.

From my side the problem is fixed.

osh added a commit that referenced this pull request Apr 22, 2015
@osh osh merged commit b75e058 into gnuradio:master Apr 22, 2015
@jmcorgan
Copy link
Contributor

Just FYI--I'm using this recipe for installation of libsodium and gr-nacl in the automated build of the livesdr snapshot image, and it is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants