-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add volk_version.h #346
add volk_version.h #346
Conversation
This change should be sufficient for GR, e.g., for the broken rotator in 2.0 that we fixed in 2.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good. But there are a few minor things.
Mostly, the question arises if volk_version.h
should be included in volk.h
. volk_malloc.h
etc. are included and I'd prefer to add this header as well.
I had thought this too, but decided to not for the initial PR. I think since |
6d33560
to
2bcd35c
Compare
|
@marcusmueller do you think the PR's addition ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hoping to get an approval from at least 1 GR dev here ... so I tagged a few! |
add volk_version.h
subject says it all. standard CMake substitutions. resulting
VOLK_VERSION
will be in the formatMAMIMT
: MA == major; MI == minor; MT == maint; any will have a preceding0
if the number is otherwise a single digit (e.g., MA of "2" will result in "02" here, but "11" will just be "11"). This is the same style as done by Boost and other projects, since it makes for simple macro-based comparisons in C / C++ code.Closes: #338