Update README.md #429
Merged
Update README.md #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advanced SIMD (aka NEON) is mandatory for AArch64. There is no need for adding extra options to the compiler for 64 bit.
jdemel
reviewed
Jan 2, 2021
michaelld
requested changes
Feb 14, 2021
There was a problem hiding this comment.
The README file needs some work ; I see a typo (likely more than 1) and some errors with respect to macOS. We need a section for how to handle Apple ARM64 / Aarch64. This change is fine, but I agree with @jdemel that I'd like to see your comment herein noted in the README file itself. @JamMarHer can you make this change? If not I'll look into a new PR that does this & more. Thx!
jdemel
approved these changes
Feb 21, 2021
|
@michaelld do we need these commits to be signed off? |
I think these are good to go as-is. They are small and not to any code. Not sure if that's what you were going for. |
|
I'm going to go ahead and merge based on my prior comment. |
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advanced SIMD (aka NEON) is mandatory for AArch64.
There is no need for adding extra options to the compiler for 64 bit.