Fix returning argument types from methods. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -433,7 +433,7 @@ unsigned method_get_number_of_arguments(struct objc_method *method) | |||
| char* method_copyArgumentType(Method method, unsigned int index) | |||
| { | |||
| if (NULL == method) { return NULL; } | |||
| const char *types = findParameterStart(method->types, index); | |||
| const char *types = findParameterStart(method->types, index + 1); | |||
There was a problem hiding this comment.
Does method_getArgumentType need the same fix? And please can we have a test case?
It did indeed.
Included now. |
| @@ -393,7 +393,7 @@ void method_getArgumentType(Method method, | |||
| size_t dst_len) | |||
| { | |||
| if (NULL == method) { return; } | |||
| const char *types = findParameterStart(method->types, index); | |||
| const char *types = findParameterStart(method->types, index + 1); | |||
There was a problem hiding this comment.
Rather than having the +1 in both places, it would probably be cleaner to fix findParaneterStart to start in the right place.
|
Good idea, thanks. Fixed now. |
davidchisnall
added a commit
that referenced
this pull request
Sep 7, 2015
Fix returning argument types from methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny fix: method_copyArgumentType() didn't account for the fact that the return type is the first element in the method signature.