Set -march flag for atomic operations builtins even when not compiling with clang #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, setting -lpthread is not enough to convince gcc to actually link a thread library, so if we are using pthreads, set the -pthread flag as well. It fixes the gcc situation and doesn't have any adverse effects for clang either.
davidchisnall
added a commit
that referenced
this pull request
Oct 12, 2015
Set -march flag for atomic operations builtins even when not compiling with clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler flag to have x86-32 code use builtins for atomic operations was only applied when compiling with clang. The attached PR sets it for all compilers.
Cheers,
Niels
btw: I have a .travis.yml for libobjc2, if you're interested in having travis jobs for each commit/PR.