Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with ICU 68 #163

Merged
merged 1 commit into from Nov 12, 2020
Merged

Fix compilation with ICU 68 #163

merged 1 commit into from Nov 12, 2020

Conversation

triplef
Copy link
Member

@triplef triplef commented Nov 12, 2020

ICU 68 no longer defines the TRUE and FALSE defines, as outlined in their updated Coding Guidelines. This causes building GNUstep with ICU 68 to fail.

@triplef triplef requested a review from rfm as a code owner November 12, 2020 16:58
@rfm rfm merged commit f7bbefd into gnustep:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfm rfm rfm approved these changes

@fredkiefer fredkiefer fredkiefer approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@triplef @rfm @fredkiefer