-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSProgress fixes branch #65
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9c4d2ca
Add NSProgress
gcasa 57f6c8b
Add NSProgress tests
gcasa 8372fac
Merge branch 'master' of github.com:gnustep/libs-base into NSProgress…
gcasa 0f09fef
Fix crash due to dictionary
gcasa 5806cc4
Fixes for existing issues reported by Algoriddim.
gcasa File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
#import <Foundation/NSProgress.h> | ||
#import <Foundation/NSThread.h> | ||
#import <Foundation/NSAutoreleasePool.h> | ||
#import "ObjectTesting.h" | ||
|
||
int main() | ||
{ | ||
NSAutoreleasePool *arp = [NSAutoreleasePool new]; | ||
NSDictionary *dict = [NSDictionary dictionary]; | ||
NSProgress *progress = [[NSProgress alloc] initWithParent: nil | ||
userInfo: dict]; | ||
PASS(progress != nil, "[NSProgress initWithParent:userInfo:] returns instance"); | ||
|
||
progress = [NSProgress discreteProgressWithTotalUnitCount:100]; | ||
PASS(progress != nil, "[NSProgress discreteProgressWithTotalUnitCount:] returns instance"); | ||
|
||
progress = [NSProgress progressWithTotalUnitCount:100]; | ||
PASS(progress != nil, "[NSProgress progressWithTotalUnitCount:] returns instance"); | ||
|
||
progress = [NSProgress progressWithTotalUnitCount:100 | ||
parent:progress | ||
pendingUnitCount:50]; | ||
PASS(progress != nil, "[NSProgress progressWithTotalUnitCount:] returns instance"); | ||
|
||
[progress becomeCurrentWithPendingUnitCount:50]; | ||
NSProgress *currentProgress = [NSProgress currentProgress]; | ||
PASS(currentProgress == progress, "Correct progress object associated with current thread"); | ||
|
||
NSProgress *new_progress = [NSProgress progressWithTotalUnitCount:100 | ||
parent:progress | ||
pendingUnitCount:50]; | ||
[new_progress addChild:[[NSProgress alloc] initWithParent: nil userInfo: nil] | ||
withPendingUnitCount:50]; | ||
|
||
[currentProgress resignCurrent]; | ||
|
||
PASS([NSProgress currentProgress] == nil, "Current progress is nil after resign current"); | ||
|
||
[arp release]; arp = nil; | ||
return 0; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unnecessary as the basic KVO mechanism should create this automatically. This is also true for some of the following methods. We should only need to add willChange.. and didChange.. methods to support different names and even for these there was a better way, if I remember correctly.