NSPopUpButton's popup menu in pulldown mode displaying fix #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
item for pulldown popup button's menu. (sizeToFit): removed commented useless code; fixed formatting. (rectOfItemAtIndex:): draw first item cell of pulldown popup menu. (setWindowFrameForAttachingToRect:onScreen:preferredEdge:popUpSelectedItem:): remove useless (was used for old-style popup menu) positionning code for popup menu. Check if owning popup is not pulldown before vertical position correction. * Source/NSPopUpButtonCell.m (attachPopUpWithFrame:inView:): make setting selected item code more generic for pulldown and non-pulldown button. Fixed formatting.
|
Some of the changes of this pull request are obviously correct. What I doubt is the overall change. Why would we want to display the title item (that is the first item in a pull down) in the menu? |
fredkiefer
requested changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the way how poup menu is displayed when popup button operates in pulldown mode. Before this change popup menu doesn't display first item and was placed to the bottom edge of popup button. Although popup menu can't draw dark gray border around poup button.
With this change pulldown menu draws exatrly the same way as in normal mode except first item is not highlighted. So now popup menu looks visually consistent no matter what mode it opeartes in.
Plus, NSMenuView contains less popup button specific code.