Skip to content

Commit

Permalink
Revert "Documented use gnutls_priority_set2()."
Browse files Browse the repository at this point in the history
This reverts commit b4aed16.
  • Loading branch information
Nikos Mavrogiannopoulos committed Jul 25, 2017
1 parent 3c2e13a commit ae6b9b2
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 14 deletions.
1 change: 0 additions & 1 deletion NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ gnutls_pubkey_export_ecc_raw2: Added
gnutls_privkey_export_rsa_raw2: Added
gnutls_privkey_export_dsa_raw2: Added
gnutls_privkey_export_ecc_raw2: Added
gnutls_priority_set2: Added
GNUTLS_EXPORT_FLAG_NO_LZ: Added
GNUTLS_DT_IP_ADDRESS: Added
GNUTLS_X509_CRT_FLAG_IGNORE_SANITY: Added
Expand Down
5 changes: 2 additions & 3 deletions doc/cha-gtls-app.texi
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ and the underlying protocol type, i.e., datagram (UDP) or reliable (TCP).

After the session initialization details on the allowed ciphersuites
and protocol versions should be set using the priority functions
such as @funcref{gnutls_priority_set2} and @funcref{gnutls_priority_set_direct}.
such as @funcref{gnutls_priority_set} and @funcref{gnutls_priority_set_direct}.
We elaborate on them in @ref{Priority Strings}.
The credentials used for the key exchange method, such as certificates
or usernames and passwords should also be associated with the session
Expand Down Expand Up @@ -1088,7 +1088,7 @@ and share the generated data across sessions. The following functions
allow the generation of a "priority cache" and the sharing of it across
sessions.

@showfuncC{gnutls_priority_init,gnutls_priority_set2,gnutls_priority_deinit}
@showfuncC{gnutls_priority_init,gnutls_priority_set,gnutls_priority_deinit}

@subheading Using Priority Strings

Expand All @@ -1099,7 +1099,6 @@ specific algorithm details, as the priority strings are not constant between
gnutls versions (they are periodically updated to account for cryptographic
advances while providing compatibility with old clients and servers).


@float Table,tab:prio-keywords
@multitable @columnfractions .20 .70
@headitem Keyword @tab Description
Expand Down
2 changes: 1 addition & 1 deletion doc/cha-intro-tls.texi
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ solves the problem by using minimal padding.
If you implement an application that has a configuration file, we
recommend that you make it possible for users or administrators to
specify a GnuTLS protocol priority string, which is used by your
application via @funcref{gnutls_priority_set2}. To allow the best
application via @funcref{gnutls_priority_set}. To allow the best
flexibility, make it possible to have a different priority string for
different incoming IP addresses.

Expand Down
4 changes: 0 additions & 4 deletions doc/cha-upgrade.texi
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,4 @@ however, there are minor differences, listed below.
@funcintref{gnutls_compression_get_name}, @funcintref{gnutls_compression_list},
and @funcintref{gnutls_compression_get_id}.

@item The @funcref{gnutls_priority_set} has been superseded by @funcref{gnutls_priority_set2}.
@tab The function @funcref{gnutls_priority_set2} allows for sharing priority
caches across multiple sessions reducing allocated memory per session.

@end multitable
2 changes: 1 addition & 1 deletion doc/examples/ex-serv-dtls.c
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ int main(void)
continue;

gnutls_init(&session, GNUTLS_SERVER | GNUTLS_DATAGRAM);
gnutls_priority_set2(session, priority_cache, 0);
gnutls_priority_set(session, priority_cache);
gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE,
x509_cred);

Expand Down
2 changes: 1 addition & 1 deletion doc/examples/ex-serv-psk.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ int main(void)
client_len = sizeof(sa_cli);
for (;;) {
gnutls_init(&session, GNUTLS_SERVER);
gnutls_priority_set2(session, priority_cache, 0);
gnutls_priority_set(session, priority_cache);
gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE,
x509_cred);
gnutls_credentials_set(session, GNUTLS_CRD_PSK, psk_cred);
Expand Down
2 changes: 1 addition & 1 deletion doc/examples/ex-serv-x509.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ int main(void)
client_len = sizeof(sa_cli);
for (;;) {
CHECK(gnutls_init(&session, GNUTLS_SERVER));
CHECK(gnutls_priority_set2(session, priority_cache, 0));
CHECK(gnutls_priority_set(session, priority_cache));
CHECK(gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE,
x509_cred));

Expand Down
2 changes: 0 additions & 2 deletions lib/priority.c
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,6 @@ gnutls_priority_set(gnutls_session_t session, gnutls_priority_t priority)
* must remain valid for the lifetime of the session.
*
* Returns: %GNUTLS_E_SUCCESS on success, or an error code.
*
* Since: 3.6.0
**/
int
gnutls_priority_set2(gnutls_session_t session, gnutls_priority_t priority, unsigned int flags)
Expand Down

0 comments on commit ae6b9b2

Please sign in to comment.