New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Role based pings #7
Conversation
As you have the API key, instead of applying a big change to the current notifybot and risk breaking that functionality maybe we can put this up for testing somewhere else but disable the standard slow-pings to avoid duplicates (or use a different prefix for testing). That would allow some "integration testing" before we deploy it. |
Glad you would say that. I actually implement support for running it in debug mode, no pings sent just logging and tags. I even tested it a bit in the test flow. |
I did some testing of my own, as described above. Very nice, good work, notifybot is growing into a real thing :-) 2 things that pop into my mind when using it.
|
@@ -21,7 +21,8 @@ type Username string | |||
type config struct { | |||
FlowdockAPIKey string `yaml:"flowdock_api_key"` | |||
StoragePath string `yaml:"storage_path"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea to make this configurable also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will make it even more persistant. I started on a new refactoring branch so I'll include it there.
It seems making it understand PM:s is as "easy" as enabling user=1 in the API https://www.flowdock.com/api/streaming I tried it, it almost worked out of the box. Current coding means it does not handle it nicely but at least we know it's possible. If you want to work on it feel free otherwise I'm happy to take a look also. |
Closing old PRs for abandoned projects. |
This PR supports role based ping as described in #3 with the exception of instant pings with
@
.