Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role based pings #7

Closed
wants to merge 14 commits into from
Closed

Role based pings #7

wants to merge 14 commits into from

Conversation

jabbors
Copy link
Contributor

@jabbors jabbors commented Feb 21, 2017

This PR supports role based ping as described in #3 with the exception of instant pings with @.

@gnyman
Copy link
Owner

gnyman commented Feb 21, 2017

As you have the API key, instead of applying a big change to the current notifybot and risk breaking that functionality maybe we can put this up for testing somewhere else but disable the standard slow-pings to avoid duplicates (or use a different prefix for testing).

That would allow some "integration testing" before we deploy it.

@jabbors
Copy link
Contributor Author

jabbors commented Feb 21, 2017

Glad you would say that. I actually implement support for running it in debug mode, no pings sent just logging and tags. I even tested it a bit in the test flow.

@gnyman
Copy link
Owner

gnyman commented Feb 21, 2017

I did some testing of my own, as described above. Very nice, good work, notifybot is growing into a real thing :-)

2 things that pop into my mind when using it.

  1. Tags vs messages is a bit unclear , some commands add tags some send a message
  2. The messages/tag editing will probably create a lot of spam, this is advanced level but it might be worth looking into moving those to PM. Or maybe just telling people to do the changes in #test as the roles are global

@@ -21,7 +21,8 @@ type Username string
type config struct {
FlowdockAPIKey string `yaml:"flowdock_api_key"`
StoragePath string `yaml:"storage_path"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to make this configurable also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will make it even more persistant. I started on a new refactoring branch so I'll include it there.

@gnyman
Copy link
Owner

gnyman commented Feb 21, 2017

It seems making it understand PM:s is as "easy" as enabling user=1 in the API

https://www.flowdock.com/api/streaming

I tried it, it almost worked out of the box. Current coding means it does not handle it nicely but at least we know it's possible. If you want to work on it feel free otherwise I'm happy to take a look also.

@jabbors
Copy link
Contributor Author

jabbors commented Dec 17, 2019

Closing old PRs for abandoned projects.

@jabbors jabbors closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants