Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newline character after error message #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add newline character after error message #198

wants to merge 1 commit into from

Conversation

JOE1994
Copy link

@JOE1994 JOE1994 commented Jul 18, 2020

Currently, error messages emitted to stderr don't end with a newline character.

  • example
lonelyjoe@lonelyjoe-desktop:~/workspace/Rust_abstractions/basicmath_large$ cargo asm
[ERROR]: cargo asm could not find any output files!lonelyjoe@lonelyjoe-desktop:~/workspace/Rust_abstractions/basicmath_large$ 
lonelyjoe@lonelyjoe-desktop:~/workspace/Rust_abstractions/basicmath_large$

This commit adds a newline character at the end of the
printed error message, to slightly improve user experience.

  • example after this commit
lonelyjoe@lonelyjoe-desktop:~/workspace/Rust_abstractions/basicmath_large$ cargo asm
[ERROR]: cargo asm could not find any output files!
lonelyjoe@lonelyjoe-desktop:~/workspace/Rust_abstractions/basicmath_large$ 
lonelyjoe@lonelyjoe-desktop:~/workspace/Rust_abstractions/basicmath_large$

Thank you for reviewing this PR 馃憤

p.s. I also made one minor change that moves branch-invariant parts out of the if-else block.

@JOE1994
Add newline character after error message
d7b7305 
Currently, when an error message is emitted to stderr,
the error message doesn't end with a newline character.
This commit adds a newline character at the end of the
printed error message, to marginally improve user experience.

Thank you for reviewing this commit :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JOE1994