Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip signedness checks for type aliases of non-integer types #43

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Skip signedness checks for type aliases of non-integer types #43

merged 1 commit into from
Oct 21, 2018

Conversation

johnschug
Copy link
Contributor

Currently signedness checks are always generated for type aliases unless they are skipped manually via
TestGenerator::skip_signededness.
This pr skips generating signedness checks for type aliases unless the types they alias are known to be integer types.

@alexcrichton
Copy link
Collaborator

Thanks for this! It looks like AppVeyor CI may be failing? Also, mind running this against the libc crate to ensure the number of tests doesn't accidentally decrease?

@johnschug
Copy link
Contributor Author

It looks like the AppVeyor failure was caused by #39 and is unrelated to the changes in this pr. I ran the libc tests locally with the updated ctest and had two failures (same as rust-lang/libc#1079 and rust-lang/libc#1080) which are unrelated to the changes here.

@alexcrichton
Copy link
Collaborator

Ok and to confirm, the number of tests didn't decrease? This seems like it could accidentally stop testing signedness which we're testing today

@johnschug
Copy link
Contributor Author

johnschug commented Oct 20, 2018

Yes, it generates a total of 16205 tests both before and after the change.

@alexcrichton
Copy link
Collaborator

Ok great, thanks!

@alexcrichton alexcrichton merged commit 9480ee3 into gnzlbg:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants