Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added convenient methods for uploading files. #15

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

adelowo
Copy link
Contributor

@adelowo adelowo commented Jul 26, 2017

Implements go-aah/aah#82

@codecov
Copy link

codecov bot commented Jul 26, 2017

Codecov Report

Merging #15 into v0-unstable will decrease coverage by 0.35%.
The diff coverage is 90.32%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v0-unstable      #15      +/-   ##
===============================================
- Coverage        98.45%   98.09%   -0.36%     
===============================================
  Files                6        6              
  Lines              389      421      +32     
===============================================
+ Hits               383      413      +30     
- Misses               5        6       +1     
- Partials             1        2       +1
Impacted Files Coverage Δ
request.go 98.02% <90.32%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab8efd...5745e40. Read the comment docs.

@jeevatkm
Copy link
Member

@adelowo You have nicely written test case. Very important one. Thank you for the PR.

I'm merging it.

@jeevatkm jeevatkm merged commit 19eeca3 into go-aah:v0-unstable Jul 26, 2017
@adelowo adelowo deleted the upload_multipart_form branch July 27, 2017 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants