Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renew command should give a non-zero exit code if the passed domains do not match an existing certificate #1156

Closed
ryantm opened this issue May 12, 2020 · 1 comment

Comments

@ryantm
Copy link

ryantm commented May 12, 2020

Hi.

Following up on #1155, as @ldez said there, it doesn't make sense to renew a certificate that has an additional alternative name added and this should be a new certificate, so if the list of domains passed to the renew command doesn't match the domains of a certificate that is already issued, it should return a non-zero exit code, so that renewal failure can be detected and the caller may try the run command.

Ryan

@ldez
Copy link
Member

ldez commented May 12, 2020

Hello,

It's a bit more ambiguous: because if you define the right number of days, you can revew and add a new certificate.

Some lego's users use that behavior, if we change this behavior to throw an error it will be a breaking change.

As I referenced in #1155, this is something we will change when we create a unified command to run/renew. (related to #693, #290, #216, #221)

@ldez ldez closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants