Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase HTTP client timeouts #1336

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Increase HTTP client timeouts #1336

merged 2 commits into from
Feb 28, 2021

Conversation

apeschar
Copy link
Contributor

@apeschar apeschar commented Jan 28, 2021 •
edited
Loading

Let's Encrypt's API is sometimes slow:

2021/01/28 09:48:33 Could not obtain certificates:
        error: one or more domains had a problem:
[*.mydomain.dev] Post "https://acme-v02.api.letsencrypt.org/acme/finalize/105472891/7570478847": net/http: timeout awaiting response headers
[mydomain.dev] Post "https://acme-v02.api.letsencrypt.org/acme/finalize/105472891/7570478847": net/http: timeout awaiting response headers
Certificate generation failed.

This prevents problems by waiting a little longer for a response.

@ldez ldez added the area/lib label Jan 28, 2021
@ldez ldez self-requested a review January 31, 2021 13:53
@ldez ldez enabled auto-merge (squash) February 28, 2021 12:47
@ldez ldez added this to the v4.3 milestone Feb 28, 2021
@ldez ldez merged commit 72c7034 into go-acme:master Feb 28, 2021
This was referenced Mar 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/lib enhancement
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@apeschar @ldez