Add support for additional AWS authentication sources #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS client tools commonly support passing credentials via `AWS_ACCESS_KEY_ID` + `AWS_SECRET_ACCESS_KEY`, but supporting only this is insufficient. For example, access key IDs provided by STS require passing in `AWS_SECURITY_TOKEN` as a third value, and EC2 instances are often provided dynamic credentials at runtime via the EC2 metadata service. This changeset makes `lego` attempt to find credentials in the same way that the `aws` CLI tool attempts to find credentials. The result is even less auth code than before because `goamz` provides all this with `aws.GetAuth()`.
|
Note also that this proposed behavior matches the official AWS SDK's default credential chain, customarily achieved by omitting the |
|
LGTM 👍 |
|
I like that this PR is a net gain in LOC because of comments, but is actually a net reduction. |
|
Great PR, thank you! |
xenolf
added a commit
that referenced
this pull request
Feb 7, 2016
Add support for additional AWS authentication sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS client tools commonly support passing credentials via
AWS_ACCESS_KEY_ID+AWS_SECRET_ACCESS_KEY, but supporting only this is insufficient. For example, access key IDs provided by STS require passing inAWS_SECURITY_TOKENas a third value, and EC2 instances are often provided dynamic credentials at runtime via the EC2 metadata service.This changeset makes
legoattempt to find credentials in the same way that theawsCLI tool attempts to find credentials. The result is even less auth code than before becausegoamzprovides all this withaws.GetAuth().