-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS challenge provider for Google Cloud DNS #141
Conversation
Thank you for this! I see that you are providing a live test only, please make sure that the live test is not run when no credentials are supplied. Please note that the package which holds the 3rd party DNS providers will change tomorrow so it will require another change. |
OK, the tests are passing when not run live. Let me know if you need any further integration with the new DNS provider package. |
@peterwald Thank you! I'm sorry that I've been a bit slow on progress with #144 but it should get merged in soon. |
@peterwald something seems to be acting up in here. Could you please rebase this PR onto current master now that #144 is merged? Thanks! |
This merge looks a lot worse than it is due to the resyncing. Even though it looks like a big change because all of the intermediate commits were included, the actual differences between the starting and ending state are small. If you'd prefer I can close out this PR and create another one that shows the changes more cleanly. |
I'd probably suggest a rebase/squash to tidy this? |
Could this PR get rebased on top of #148? This allows you to customize the timeout and interval of the dns pre-check and thus removes the need to export the function. |
Use GCE_PROJECT to designate your GCE project. Authentication is automatically picked up from gcloud credentials if running locally and from GCE metadata if run within Google Cloud. Requires at least permission scope "https://www.googleapis.com/auth/ndev.clouddns.readwrite"
Rebased on #148 and squashed. |
Add DNS challenge provider for Google Cloud DNS
Use GCE_PROJECT to designate your GCE project.
Authentication is automatically picked up from gcloud credentials if
running locally and from GCE metadata if run within Google Cloud.
Requires at least permission scope
"https://www.googleapis.com/auth/ndev.clouddns.readwrite"