New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azuredns: provide the ability to select authentication methods #2026
azuredns: provide the ability to select authentication methods #2026
Conversation
f4ab2aa
to
e2a643b
Compare
Hi, what is the value of disabling some auth methods instead of choosing only one? |
Hello, |
We can keep the default and choose one with only one option. |
Hello, I have updated the PR according to your suggestion. |
I think you did not understand my 2 previous messages: I was speaking about 1 option instead of 5 options, and not changing the default option values. |
Hello, |
You can mimic the terraform provider but I need to know if being able to use several auth methods is a real thing or not, it's not a pro/con. I need more concrete arguments to justify if auth method fallback is a thing for Azure users. |
The fallback mechanism can be useful during the development phase on a local machine. The
In a production environment for a workload or CI/CD usage, defining one and only one authentication method is viable because it is determined by the context of the workload or CI/CD environment. |
Hello,
After using
azuredns
new DNS provider, I figured out it could be really useful to manage which authentication methods to use, in order to configure more accurately the expected behavior.Therefore, I have splited the
DefaultAzureCredential
by using the different Azure credential methods and added the possibility to disable some of them.Note that for
NewManagedIdentityCredential
I added a timeout management as described in the azidentity package documentationLet me know if you want me to add anything.
Thanks.