gandiv5: Add "Bearer" prefix to the auth header #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Bearer" prefix is required per https://api.gandi.net/docs/authentication/ to declare the content of the Authorization header as a personal access token. Without this change, the user has to specify GANDIV5_PERSONAL_ACCESS_TOKEN='Bearer 12341234' instead of GANDIV5_PERSONAL_ACCESS_TOKEN=12341234 which disagrees with the documentation and the existing test data. This change is not backwards-compatible. This should be OK because the commit 113648a which added support for personal access tokens was not in any release yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Bearer" prefix is required per
https://api.gandi.net/docs/authentication/ to declare the content of the Authorization header as a personal access token.
Without this change, the user has to specify
GANDIV5_PERSONAL_ACCESS_TOKEN='Bearer 12341234'instead ofGANDIV5_PERSONAL_ACCESS_TOKEN=12341234which disagrees with the documentation and the existing test data.This change is not backwards-compatible. This should be OK because the commit 113648a (#2007) which added support for personal access tokens was not in any release yet.