Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve errors and logs related to DNS call #2109

Merged
merged 3 commits into from Feb 11, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 10, 2024

I improved errors and logs related to DNS calls: better information related to the context (FQDN, zone, NS, DNS message, ...)

Also, with the new error type, every error returned by sendDNSQuery (and dnsQuery) will contain the questions (ex: example.com. IN SOA), so it will be far easier to diagnose DNS call problems.

Otherwise, when we iterate nameservers to do DNS calls if the latest call returns an error then we report all the errors of the previous calls instead of only the latest error.

Also, I added the FDQN inside the error message of FindZoneByFqdn, FindZoneByFqdnCustom, and FindPrimaryNsByFqdnCustom, so we can remove that from the error handling of the callers.

The log message:

Checking DNS record propagation using [1.1.1.1:53 8.8.8.8:53 9.9.9.9:53]

is now:

Checking DNS record propagation. [nameservers=1.1.1.1:53 8.8.8.8:53 9.9.9.9:53]

The previous message was not exactly wrong but it could be misinterpreted.
Now the nameservers are just a piece of context information.

Fixes #2097

@ldez ldez added this to the v4.16 milestone Feb 10, 2024
@ldez ldez requested a review from dmke February 10, 2024 19:21
@ldez ldez changed the title chore: improve errors and logs related to DNS call feat: improve errors and logs related to DNS call Feb 11, 2024
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit ba67a26 into go-acme:master Feb 11, 2024
7 checks passed
@ldez ldez deleted the feat/improve-errors-dns branch February 11, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Misleading log output
2 participants