feat: improve errors and logs related to DNS call #2109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved errors and logs related to DNS calls: better information related to the context (FQDN, zone, NS, DNS message, ...)
Also, with the new error type, every error returned by
sendDNSQuery
(anddnsQuery
) will contain the questions (ex:example.com. IN SOA
), so it will be far easier to diagnose DNS call problems.Otherwise, when we iterate nameservers to do DNS calls if the latest call returns an error then we report all the errors of the previous calls instead of only the latest error.
Also, I added the FDQN inside the error message of
FindZoneByFqdn
,FindZoneByFqdnCustom
, andFindPrimaryNsByFqdnCustom
, so we can remove that from the error handling of the callers.The log message:
is now:
The previous message was not exactly wrong but it could be misinterpreted.
Now the nameservers are just a piece of context information.
Fixes #2097