Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exoscale: simplify record creation #2179

Merged
merged 1 commit into from
May 7, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented May 6, 2024

Instead of updating a record, it always creates a new record.

To find the record to delete, the record value is used.

Fixes #2174

Copy link

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix/exoscale-update-record branch from 0c29142 to 91f8d78 Compare May 7, 2024 10:13
@ldez ldez enabled auto-merge (squash) May 7, 2024 10:13
@ldez ldez merged commit f6d1413 into go-acme:master May 7, 2024
4 checks passed
@ldez ldez deleted the fix/exoscale-update-record branch May 7, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

exoscale: fails when issuing certificate for "*.domain.example" and "domain.example"
3 participants