Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acme v2 Support #555

Merged
merged 22 commits into from
May 30, 2018
Merged

Acme v2 Support #555

merged 22 commits into from
May 30, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented May 30, 2018

Merge the branch acmev2 into master.

Closes #457

xenolf and others added 22 commits March 14, 2018 02:04
@xenolf
Initial ACMEv2 support WIP
3d582c0
@xenolf
Add missing return on error when order creation fails
805eec9
@xenolf
Fix certificate load with wildcard name
a149e7d
@jammm
providers/azure: Refactor to work with Azure SDK version 14.0.0 (#490)
c62cb65
Fix tests in ACMEv2
0b6d953
@mikepulaski @xenolf
Fixed CN regression in ACMEv2. (#515)
5d4f14b
@xenolf
Fix error return when Order could not be created
9408374
@xenolf
Refactor error code in obtain functions to return a canonical error
6e962fb
@mikepulaski @xenolf
ResolveAccountByKey no longer returns an EOF error on success. (#518)
823a03a 
* ResolveAccountByKey no longer returns an EOF error on success.

* Added test for ResolveAccountByKey.
@mholt
Fix non-nil error value when there is no error
fad2257
@mholt
Merge branch 'master' into acmev2
ef5b5bf 
# Conflicts:
#	providers/dns/azure/azure.go
@wyattjoh
Resolved build errors, small changes
8a99020 
- Switched out some value -> pointer returns
  for functions that returned an error
- Switched out previous failures map with an
  error
@robaman @ldez
Add External Account Binding support. (#516)
5115a95 
* Second draft of External Account Binding support with xenolf's proposed
changes included.
* Require --eab if the ACME directory says it requires External Account
Binding.
* Inner EAB JWS should not contain any nonce. Ref: https://ietf-wg-acme.github.io/acme/draft-ietf-acme-acme.html#rfc.section.7.3.5
@ldez
refactor: CRLF to LF.
32052a8
@ldez
refactor: sort imports.
2cdb0e9
@ldez
feat: replace v1 by v2.
76cb778
@ldez
feat: create log package.
56911d8
@ldez
refactor: use new logger.
eed8169
@ldez
chore: change Travis configuration.
ff6a346 
- remove go1.8, due to miekg/dns#683
- add go1.x
@ldez
refactor: clean residual TLS challenge data.
1f0c69a
@ldez
refactor: linting.
9a1f8d7
@ldez
Merge branch 'acmev2' into master
838c6ba
mholt
mholt approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using the v2 branch for months in production. Needs a little work but nothing major AFAICT. Merge away!

@ldez ldez merged commit e7fd871 into master May 30, 2018
@ldez ldez deleted the feature/merge-acmev2 branch May 30, 2018 17:53
@ldez ldez changed the title Merge acmev2 into master Acme v2 Support May 30, 2018
@ldez ldez added the area/lib label May 30, 2018
@ldez ldez modified the milestones: v0.1.0, v1.0 Dec 7, 2018
@greut greut mentioned this pull request Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
area/lib
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ldez @mholt @xenolf @jammm @mikepulaski @wyattjoh @robaman