Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
ec2/ec2test: handle "tag:" filter for volumes #56
Conversation
wallyworld
reviewed
Jul 22, 2015
| + | ||
| + filter := ec2.NewFilter() | ||
| + filter.Add("tag:key", "value") | ||
| + resp, err := s.ec2.Volumes(nil, filter) |
wallyworld
Jul 22, 2015
Member
maybe also a check that the volume fails to match the filter before the tags are added
|
LGTM |
added a commit
that referenced
this pull request
Jul 22, 2015
axw
merged commit 6b2122e
into
go-amz:v3
Jul 22, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedJul 22, 2015
Handle the "tag:key=value" type filter for
volumes. This is required for Juju to be able
to list volumes belonging to an environment.