This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
ec2/ec2test: handle "tag:" filter for volumes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| filter := ec2.NewFilter() | ||
| filter.Add("tag:key", "value") | ||
| resp, err := s.ec2.Volumes(nil, filter) |
There was a problem hiding this comment.
maybe also a check that the volume fails to match the filter before the tags are added
|
LGTM |
Handle the "tag:key=value" type filter for volumes. This is required for Juju to be able to list volumes belonging to an environment.
axw
force-pushed
the
ec2test-volumes-filter-tag
branch
from
b4e3d1d
to
9728e8c
Compare
axw
added a commit
that referenced
this pull request
Jul 22, 2015
ec2/ec2test: handle "tag:" filter for volumes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the "tag:key=value" type filter for
volumes. This is required for Juju to be able
to list volumes belonging to an environment.