/amz

ec2test: handle security group tags #67

Merged
merged 1 commit into from Apr 20, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@axw @wallyworld
@axw
Member

axw commented Apr 18, 2016

Update CreateTags and security group filtering to handle tags.

Also update "reservation.hasRunningMachine" to perform
the same advance-from-shuttingdown-to-terminated logic
that is applied in "DescribeInstances". This is necessary
to avoid DependencyViolation errors when running the
tests in Juju.
@axw
ec2test: handle security group tags 
Update CreateTags and security group filtering
to handle tags.
2c9d0c5

@axw axw referenced this pull request in juju/juju Apr 18, 2016

Merged

provider/ec2: destroy hosted model resources #5197

@wallyworld
Member

wallyworld commented Apr 20, 2016

LGTM

@axw axw merged commit a651c43 into go-amz:v3 Apr 20, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jujubot added a commit to juju/juju that referenced this pull request Apr 29, 2016

@jujubot
Merge pull request #5197 from axw/environ-destroy-hosted-models-ec2 
provider/ec2: destroy hosted model resources

When calling the Destroy() method of a controller's
Environ, we will also destroy the resources for the
hosted models created/managed by the controller.

Also, ListVolumes has been fixed to no longer report
root disks.

Requires go-amz/amz#67

Partially fixes https://bugs.launchpad.net/juju-core/+bug/1566011
Fixes https://bugs.launchpad.net/juju-core/+bug/1550074

(Review request: http://reviews.vapour.ws/r/4625/)
7bd9ceb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment