This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
ec2test: handle security group tags #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CreateTags and security group filtering to handle tags.
|
LGTM |
jujubot
added a commit
to juju/juju
that referenced
this pull request
Apr 29, 2016
provider/ec2: destroy hosted model resources When calling the Destroy() method of a controller's Environ, we will also destroy the resources for the hosted models created/managed by the controller. Also, ListVolumes has been fixed to no longer report root disks. Requires go-amz/amz#67 Partially fixes https://bugs.launchpad.net/juju-core/+bug/1566011 Fixes https://bugs.launchpad.net/juju-core/+bug/1550074 (Review request: http://reviews.vapour.ws/r/4625/)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CreateTags and security group filtering to handle tags.
Also update "reservation.hasRunningMachine" to perform
the same advance-from-shuttingdown-to-terminated logic
that is applied in "DescribeInstances". This is necessary
to avoid DependencyViolation errors when running the
tests in Juju.