Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

弹窗显示jenkins流水线日志 #109

Merged
merged 3 commits into from Mar 31, 2022
Merged

弹窗显示jenkins流水线日志 #109

merged 3 commits into from Mar 31, 2022

Conversation

sampsonye
Copy link
Collaborator

@sampsonye sampsonye commented Mar 28, 2022 •
edited

Which changes (Bug/Feature):

Fixes #106

弹窗显示：
image

最大化显示：
image

Special notes for reviewers:

none

@sampsonye sampsonye requested review from colynn and fanhousanbu and removed request for colynn March 29, 2022 00:23
fanhousanbu
fanhousanbu reviewed Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@fanhousanbu fanhousanbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code formatted, it's hard to review, i doubt it's some kind of escape from code review 💯

fanhousanbu
fanhousanbu reviewed Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@fanhousanbu fanhousanbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fanhousanbu
fanhousanbu approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@fanhousanbu fanhousanbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good

@sampsonye sampsonye merged commit 413e388 into go-atomci:v1.5.0-feat-app-refactor Mar 31, 2022
@colynn colynn self-requested a review March 31, 2022 03:49
@sampsonye sampsonye mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanhousanbu fanhousanbu fanhousanbu approved these changes

@colynn colynn Awaiting requested review from colynn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

构建日志页面建议弹窗显示
2 participants
@sampsonye @fanhousanbu