Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git for gogs #118

Merged

Conversation

yoyofx
Copy link
Contributor

@yoyofx yoyofx commented Apr 21, 2022

Feature:

添加仓库gogs支持

Copy link
Member

@colynn colynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoyofx 感谢pr,
提如下两点,辛苦确认下

  1. scm的type 统一使用constant/const.go 的定义吧,对于gogs可以新增下
  2. 前端的 views/setting/ScmIntegrate.vue 相关也需要支持;

Copy link
Member

@colynn colynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@colynn colynn merged commit 3380b8d into go-atomci:v1.5.0-feat-app-refactor Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants