Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix issue127 compile env edit failed #128

Merged

Conversation

fanhousanbu
Copy link
Collaborator

Which changes (Bug/Feature):

Fixes #127

Special notes for reviewers:

optional editor in `编译环境` and `服务集成` allowed to be empty

2. rename var `jenkins` to `jnkCfg` resolve the conflict of package's name `jenkins`
@codecov-commenter
Copy link

Codecov Report

Merging #128 (99d24fd) into master (e44a877) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files           4        4           
  Lines         163      163           
=======================================
  Hits           68       68           
  Misses         93       93           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e44a877...99d24fd. Read the comment docs.

Copy link
Member

@colynn colynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@colynn colynn merged commit e0cd0c2 into go-atomci:master Apr 30, 2022
@fanhousanbu fanhousanbu deleted the bugfix-issue127-compile_env_edit_failed branch May 5, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile env edit failed
3 participants