feat: #132 支持公共库 #133
Merged
feat: #132 支持公共库 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colynn
approved these changes
May 10, 2022
There was a problem hiding this comment.
thanks, 很好的一次提交！
只是现在 Jenkins pipeline 再运行时也会依赖 user和token ， 用于jnlp镜像内的app_checkout.py ，我来单独做一个兼容，更新下jnlp的镜像版本, 然后我们可以合并这个提交。
|
/LGTM
|
sampsonye
approved these changes
May 11, 2022
|
fanhousanbu
approved these changes
May 12, 2022
| } | ||
| p.Data["json"] = NewResult(true, rsp, "") | ||
| p.ServeJSON() | ||
| } | ||
|
|
||
| // 获取仓库域名 | ||
| // TODO现在用反射获取，有更好方法再替换 | ||
| func getBaseConfigUrl(config interface{}) string { |
There was a problem hiding this comment.
将interface{}变更为强类型，或者接口？这样更OO
There was a problem hiding this comment.
config是 interface{} 是由 pm.GetIntegrateSettings返回定义好的
@sampsonye 可以将第1点转为 issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which changes (Bug/Feature):
支持 #132
Special notes for reviewers: