Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化Registry连接失败时的提示信息 #140

Merged
merged 1 commit into from May 14, 2022

Conversation

sampsonye
Copy link
Collaborator

  1. 调整为中文提示
  2. 拆分测试请求,针对不同测试给出不同错误提示

Which changes (Bug/Feature):

Fixes #136

Special notes for reviewers:

1.5.1 Harbor可以正常集成
本次主要优化错误提示信息,方便更快定位问题

1. 调整为中文提示
2. 拆分测试请求,针对不同测试给出不同错误提示
@sampsonye sampsonye requested a review from colynn May 14, 2022 05:36
@codecov-commenter
Copy link

Codecov Report

Merging #140 (bba4ebe) into master (44743c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files           4        4           
  Lines         163      163           
=======================================
  Hits           68       68           
  Misses         93       93           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44743c4...bba4ebe. Read the comment docs.

Copy link
Member

@colynn colynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@colynn colynn merged commit 89b9803 into go-atomci:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.5.1 的harbor 作为镜像仓库无法集成配置
3 participants