Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add version print #158

Merged
merged 3 commits into from Jun 7, 2022
Merged

Feat add version print #158

merged 3 commits into from Jun 7, 2022

Conversation

colynn
Copy link
Member

@colynn colynn commented Jun 6, 2022

Which changes (Bug/Feature):

add Feat version print

Special notes for reviewers:

3a727410b627e1d20cfb1f0c27aeb9b7

@colynn colynn requested a review from sampsonye June 7, 2022 05:54
Dockerfile Outdated
@@ -1,11 +1,11 @@
## build
FROM golang:1.15-alpine AS build-env
FROM colynn/golang:1.15-alpine AS build-env
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest use offical golang base image like golang:1.15-buster

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, changed

Copy link
Collaborator

@sampsonye sampsonye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@colynn colynn merged commit 956d3a7 into go-atomci:master Jun 7, 2022
@colynn colynn deleted the feat-add-version branch August 7, 2023 08:31
@colynn colynn restored the feat-add-version branch August 7, 2023 08:31
@colynn colynn deleted the feat-add-version branch August 7, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants