Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 154 unique env name #163

Merged
merged 3 commits into from Jun 10, 2022

Conversation

fanhousanbu
Copy link
Collaborator

Which changes (Bug/Feature):

Fixes #154

Special notes for reviewers:

compile env name is unique when add / modify(case insensitive); 
history data can't be save while saving on edit page

@codecov-commenter
Copy link

Codecov Report

Merging #163 (81742ea) into master (f3c5ecc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files           4        4           
  Lines         163      163           
=======================================
  Hits           68       68           
  Misses         93       93           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c5ecc...81742ea. Read the comment docs.

Copy link
Collaborator

@sampsonye sampsonye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@fanhousanbu fanhousanbu requested a review from colynn June 10, 2022 15:20
Copy link
Member

@colynn colynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@colynn colynn merged commit db9a5b6 into go-atomci:master Jun 10, 2022
@fanhousanbu fanhousanbu deleted the feat-154-unique-env-name branch June 12, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

项目编译环境配置
4 participants