Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持任何V2版本的Registry作为镜像仓库 #37

Merged
merged 2 commits into from Jan 7, 2022
Merged

支持任何V2版本的Registry作为镜像仓库 #37

merged 2 commits into from Jan 7, 2022

Conversation

sampsonye
Copy link
Collaborator

Which changes (Bug/Feature):

Fixes #6

Special notes for reviewers:

1. support all normal docker registry
2. support insecure & secure registry endpoint
3. change 'harbor' to 'registry'

Attention

this pr need init.sh support

1. support all normal docker registry
8a930de 
2. support insecure & secure registry endpoint
3. change 'harbor' to 'registry'
@sampsonye
Copy link
Collaborator Author

未解决项：

  1. 默认采用Registry Name作为k8s secret的name，会导致Registry Name设置受限
  2. 升级脚本不可重复执行

colynn
colynn approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@colynn colynn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pertty good, very thanks @sampsonye

colynn
colynn reviewed Jan 6, 2022
View reviewed changes
core/pipelinemgr/uitls.go
Command := fmt.Sprintf("sh \"cd %v; export DOCKER_CONFIG=$DOCKER_CONFIG; /kaniko/executor -f %v -c ./ -d %v --insecure --skip-tls-verify --insecure-pull \"", appPath, dockerfile, imageURL)
var insecure = ""
if isHttps, _ := strconv.ParseBool(deployInfo[3]); !isHttps {
insecure = "--insecure --skip-tls-verify --insecure-pull"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于 推送仓库是https, 但是from 却是 非安全的场景，还是不能满足

@colynn
Copy link
Member

colynn commented Jan 6, 2022

After I fix the issue of upgrade script, it will be merged

@colynn colynn added the kind/feature Categorizes issue or PR as related to a new feature label Jan 6, 2022
@sampsonye
Copy link
Collaborator Author

通过创建临时存储过程的方式实现了表变更可以重复执行

@colynn colynn merged commit 76e786c into go-atomci:master Jan 7, 2022
@colynn colynn removed the kind/feature Categorizes issue or PR as related to a new feature label Jan 7, 2022
@colynn colynn added this to In progress in AtomCI 1.x Roadmap Jan 25, 2022
@colynn colynn moved this from In progress to Done in AtomCI 1.x Roadmap Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colynn colynn colynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
AtomCI 1.x Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

是否考虑支持将 阿里云容器服务作为镜像仓库？
2 participants
@sampsonye @colynn