allow logRotateAge option to be set to 0 #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请描述场景 |
|
改成不老化，会导致这次变更后，磁盘逐渐写满，属于不兼容变更 |
| @@ -105,7 +105,7 @@ func checkPassLagerDefinition(option *Options) { | |||
| option.LoggerFile = "log/chassis.log" | |||
| } | |||
|
|
|||
| if option.LogRotateAge <= 0 || option.LogRotateAge > 10 { | |||
| if option.LogRotateAge < 0 || option.LogRotateAge > 10 { | |||
tianxiaoliang
changed the title
tianxiaoliang
changed the title
tianxiaoliang
changed the title
kkf1
changed the title
kkf1
changed the title
little-cui
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此次变更将提供设置日志文件不老化的选项，也即LogRotateAge=0
以前情况：不设置老化天数LogRotateAge或者设置LogRotateAge=0，系统将默认设置LogRotateAge=1，也即老化天数默认为1天